SystemParametersInfo sets wallpaper completly black (using SPI_SETDESKWALLPAPER)

8.8k views Asked by At

I try to change my desktop wallpaper. It works just fine when I use it like this:

SystemParametersInfo(SPI_SETDESKWALLPAPER, 0, "C:\\1.jpg", SPIF_SENDCHANGE);

But when I use it like this, the desktop wallpaper is set completly black:

std::string s = "C:\\1.jpg";
SystemParametersInfo(SPI_SETDESKWALLPAPER, 0, &s, SPIF_SENDCHANGE);

I tried to get some more info via using GetLastError(), but the return value is just 0. I also tried to use .png-files, but this doesn't change anything.

Any ideas what I am doing wrong?

2

There are 2 answers

7
Violet Giraffe On BEST ANSWER

Try this:

SystemParametersInfo(SPI_SETDESKWALLPAPER, 0, (void*)s.c_str(), SPIF_SENDCHANGE);

The SystemParametersInfo function doesn't accept std::string pointer as path, it accepts a null-terminated char array. Which is what the c_str() method of std::string provides.

1
SaNtHoSh SaN On

Instead of using "C:\\1.jpg", use @"C:\1.jpg". This resolves the issue.