Invalid constructor reference when using local class?

3.5k views Asked by At

Given the following code:

package com.gmail.oksandum.test;

import java.util.ArrayList;
import java.util.List;

public class Test {

    public static void main(String[] args) {
    }

    public void foo() {
        class LocalFoo {

            LocalFoo(String in) {
                //Some logic
            }

        }

        List<String> ls = new ArrayList<>();
        ls.stream().map(LocalFoo::new); //Line 21
    }

}

my IDE gives me no errors. That is, until I try to build the project and run it. When I do that it gives me a compiler error that looks like this:

Error:(21, 24) java: incompatible types: cannot infer type-variable(s) R
    (argument mismatch; invalid constructor reference
      cannot access constructor LocalFoo(java.lang.String)
        an enclosing instance of type com.gmail.oksandum.test.Test is not in scope)

Now, I figured, given the error message, that this wouldn't happen if foo() were static. And quite right, this only happens if foo() is an instance method. And it only happens if LocalFoo is a local class in the instance method, and only if a constructor reference is used (i.e never a regular method reference).

What's more, if I change line 21 into

ls.stream().map(str -> new LocalFoo(str));

the compiler suddenly gives no error.

So to recap. If I try to use a constructor reference on a local class declared within an instance method, the compiler complains about not being able to access the constructor, about which I am confused.

If someone could shed some light on why this happens it would be appreciated. Thanks.

2

There are 2 answers

5
Claude Martin On BEST ANSWER

It looks like LocalFoo is treated somehow like a non-static class. That's why it claims no instance of Test is in scope.

From the tutorial:

Local classes are non-static because they have access to instance members of the enclosing block. Consequently, they cannot contain most kinds of static declarations.

https://docs.oracle.com/javase/tutorial/java/javaOO/localclasses.html

The method foo() or the class LocalFoo must be static for this to work. But a class inside a method can't be declared as static. So you'd have to move it out of the method if foo() should remain nonstatic (as an inner, static class). Another option is to just use this:
ls.stream().map(s -> new LocalFoo(s));

There should be a way to just say Test.this.LocalFoo, but that doesn't work. And if it did the compiler should also just accept LocalFoo::new.

There is a bug report now: https://bugs.openjdk.java.net/browse/JDK-8144673
(See comment by Brian Goetz)

3
PipoTells On

One problem is that you are trying to instantiate the Arraylist by specifying the generic type in the list, but not using the same type in the Arraylist.

Use : List ls = new ArrayList();

Also please provide a default constructor for LocalFoo