Using BufferedOutputStream to write bytes to file with while loop. Help needed

1.4k views Asked by At

I'm trying to write bytes to a file with a BufferedOutputStream but I need this to work in a while loop. This is mean to work with a TFTP server. It writes the file with absolutely nothing in it (which is pointless). Can anyone help me with this?

            WRQ WRQ = new WRQ();
            ACK ACK = new ACK();
            DatagramPacket outPacket;
            BufferedOutputStream bufferedOutput = new BufferedOutputStream(new FileOutputStream(filename));
            byte[] bytes;
            byte[] fileOut;
            outPacket = WRQ.firstPacket(packet);
            socket.send(outPacket);

            socket.receive(packet);

            while (packet.getLength() == 516){

            bytes = WRQ.doWRQ(packet);
            bufferedOutput.write(bytes);

            outPacket = ACK.doACK(packet);
            socket.send(outPacket);

            socket.receive(packet); 

            }

            bytes = WRQ.doWRQ(packet);
            bufferedOutput.write(bytes);

            outPacket = ACK.doACK(packet);
            socket.send(outPacket);
4

There are 4 answers

0
Louis Wasserman On

You're not closing the stream when you're done with it.

0
Danish Shrestha On

Are you missing bufferedOutput.flush() to flush out all the buffered data.

0
Kazekage Gaara On

Just try and close your BufferedOutputStream.

Add bufferedOutput.close();

If you don't close your OutputStream, you could lose buffered data, that is what is happening in your case maybe. Either close it, or flush it.

0
user1348384 On

You will need to use the BufferedOutputStream's flush() method so that all results would be written out. Invoking the close() method also performs a flush().

http://www.javapractices.com/topic/TopicAction.do?Id=8