Text editor separator line numbers overlap & long line marker

Question

I am working on a project to create a Text Editor (notepad, basically), in Swing and i have encountered a problem with the line numbers. I must say i am fairly new to java, but i am doing my best to change that!

You have below the class that handels the line numbers in the JEditorPane I am using. But everytime it ads another digit to the line numbers, I get a duplicate separator line for ~10 lines of text. How can i prevent this from happening.

Also, how can I add a "Long line marker", just another line drawn at about 100 'm' characters from the left.

This is the class:

/**
 * Part of the source code got from here:
 * developer.com/java/other/article.php/3318421/Add-Line-Numbering-in-the-JEditorPane.htm
 *
 * About the Author Stanislav Lapitsky is an offshore software developer and
 * consultant with more than 7 years of programming experience. His area of
 * knowledge includes java based technologies and RDBMS.
 *
 */
package MainGUI;

/**
 *
 * @author mrbigheart
 */
import java.awt.*;
import javax.swing.*;
import javax.swing.text.*;

public class LineNumbers {

    // private default constructor
    private LineNumbers() {
    }

    // private constructor
    private LineNumbers(JEditorPane edit) {
        edit.setEditorKit(new NumberedEditorKit());
    }

    // static factory
    public static LineNumbers valueOf(JEditorPane edit) {
        return new LineNumbers(edit);
    }

}

class NumberedEditorKit extends StyledEditorKit {

    @Override
    public ViewFactory getViewFactory() {
        return new NumberedViewFactory();
    }
}

class NumberedViewFactory implements ViewFactory {

    @Override
    public View create(Element elem) {
        String kind = elem.getName();
        if (kind != null) {
            switch (kind) {
                case AbstractDocument.ContentElementName:
                    return new LabelView(elem);
                case AbstractDocument.ParagraphElementName:
                    // return new ParagraphView(elem);
                    return new NumberedParagraphView(elem);
                case AbstractDocument.SectionElementName:
                    return new BoxView(elem, View.Y_AXIS);
                case StyleConstants.ComponentElementName:
                    return new ComponentView(elem);
                case StyleConstants.IconElementName:
                    return new IconView(elem);
            }
        }
        // default to text display
        return new LabelView(elem);
    }

}

final class NumberedParagraphView extends ParagraphView {

    public static short NUMBERS_WIDTH = 30;

    public NumberedParagraphView(Element e) {
        super(e);
        short top = 7;
        short left = 0;
        short bottom = 0;
        short right = 0;
        this.setInsets(top, left, bottom, right);
    }

    // indent for the JEditorPane
    @Override
    protected void setInsets(short top, short left, short bottom,
            short right) {
        super.setInsets(top, (short) (left + NUMBERS_WIDTH + 5),
                bottom, right);
    }

    @Override
    public void paintChild(Graphics g, Rectangle r, int n) {
        super.paintChild(g, r, n);
        View parent = this.getParent();
        int previousLineCount = getPreviousLineCount();
        int numberX = r.x - getLeftInset();
        int numberY = r.y + r.height - 5;

        //  Update sizes when number of digits in the line number changes
        int lines = getPreviousLineCount();
        int digits = Math.max(String.valueOf(lines).length(), 2);
        FontMetrics fontMetrics = g.getFontMetrics();
        //get the width of a zero character times the number of digits
        int width = (fontMetrics.charWidth('0') * digits) + numberX + 7;
        // update NUMBERS_WIDTH with the new width
        NUMBERS_WIDTH = (short)width;

        // line numbers rectangle (x, y, width, height)
        g.drawRect(0, 0, width, parent.getContainer().getHeight());
        g.setColor(Color.YELLOW);
        g.drawString(Integer.toString(previousLineCount + n + 1),
                numberX, numberY);
    }

    public int getPreviousLineCount() {
        int lineCount = 0;
        View parent = this.getParent();
        int count = parent.getViewCount();
        for (int i = 0; i < count; i++) {
            if (parent.getView(i) == this) {
                break;
            } else {
                lineCount += parent.getView(i).getViewCount();
            }
        }
        return lineCount;
    }
}

Thank you in advance!

Answer 1

This seemed to be an improvement for me. Force the width and NUMBERS_WIDTH to be the max it has ever been with Math.max() in paintChild():

...

int width = (fontMetrics.charWidth('0') * digits) + numberX + 7;
// update NUMBERS_WIDTH with the new width
NUMBERS_WIDTH = (short) Math.max(NUMBERS_WIDTH, width);

// line numbers rectangle (x, y, width, height)
g.drawRect(0, 0, NUMBERS_WIDTH, parent.getContainer().getHeight());

...