Sails.js with passport-http-bearer authentication not working

2.8k views Asked by At

I'm using multiple strategies with passport (local and bearer strategies). The login with local strategy works. We generate a token after login, and the token is stored in redis. After the initial login I want to use bearer auth with no session as long as the token is found in redis. If I send the correct token I can query redis and get the user data, but node still sends a 403 response instead of the 200 status code I'm expecting. If the token is not found in redis, sails crashes with the following error:

 /workspace/rs-api-sails/node_modules/redis/index.js:587
            throw err;
                  ^
Error: Can't set headers after they are sent.
  at ServerResponse.OutgoingMessage.setHeader (http.js:691:11)
  at ServerResponse.res.setHeader (/workspace/rs-api-sails/node_modules/sails/node_modules/express/node_modules/connect/lib/patch.js:59:22)
  at allFailed (/workspace/rs-api-sails/node_modules/passport/lib/passport/middleware/authenticate.js:153:13)
  at attempt (/workspace/rs-api-sails/node_modules/passport/lib/passport/middleware/authenticate.js:232:28)
  at Context.delegate.fail (/workspace/rs-api-sails/node_modules/passport/lib/passport/middleware/authenticate.js:227:9)
  at Context.actions.fail (/workspace/rs-api-sails/node_modules/passport/lib/passport/context/http/actions.js:35:22)
  at verified (/workspace/rs-api-sails/node_modules/passport-http-bearer/lib/strategy.js:125:19)
  at /workspace/rs-api-sails/config/bootstrap.js:40:18
  at try_callback (/workspace/rs-api-sails/node_modules/redis/index.js:580:9)
  at RedisClient.return_reply (/workspace/rs-api-sails/node_modules/redis/index.js:670:13)
10 Dec 13:25:15 - [nodemon] app crashed - waiting for file changes before starting...

Here's the code for bearer authentication in bootstrap.js:

passport.use(new BearerStrategy(
  function(token, done) {
    var redis = require("redis"),
    client = redis.createClient(null, null, {detect_buffers: true});

    client.get(token, function (err, reply) {
      if (reply === null) {
        // if token is not a key in redis, node throws the headers already sent error
        return done(null, false);
      } else {
        User.findOne({ id: reply.toString() }).done(function(err, user) {
          sails.log(user);

          // here we get the user data from waterline but node still sends a 403
          return done(null, user);
        });
      }
    });
  }
));  

This code is in policies/isAuthenticated.js:

module.exports = function(req, res, next) {
  var passport = require('passport');    

  passport.authenticate('bearer', { session: false })(req, res, next);  

  // User is allowed, proceed to the next policy, 
  // or if this is the last policy, the controller
  if (req.isAuthenticated()) {
    return next();
  }

  // User is not allowed
  // (default res.forbidden() behavior can be overridden in `config/403.js`)
  return res.forbidden('You are not permitted to perform this action.');
};

I'm new to node, any help is much appreciated!

1

There are 1 answers

0
noahpiper On

Update: Seems to be working now after a few changes to policies/isAuthenticated.js:

var passport = require('passport');   

module.exports = function(req, res, next) { 

  passport.authenticate('bearer', { session: false }, function(err, user, info) {

    if (req.isAuthenticated()) {
      // user is allowed through local strategy
      return next();
    }  

    if (err) {
      return res.send(403, { error: 'Error: ' + info });        
    }

    if (!user) {
      return res.send(403, { error: 'Invalid token' });
    } 

    if (user) {
      sails.log(user);
      return next();
    }

    // (default res.forbidden() behavior can be overridden in `config/403.js`)
    return res.forbidden('You are not permitted to perform this action.');    

  })(req, res, next);

};