puppet service wont start

Question

I have the following code for a small class for Tomcat, The class runs fine but the service at the end of the script doesn't start. any guidance would be great. i dont know why the service wont start.

content of the Tomcat6 class

# Class: tomcat6
#
# This module manages tomcat6
#
# Parameters: none
#
# Actions:
#
# Requires: see Modulefile
#
# Sample Usage:
#
class tomcat6 ( $parentdir               = '/usr/share',
                $tomcat_version          = '6.0.37',
                $tomcat_major_version    = '6',
                $digest_string           = '171d255cd60894b29a41684ce0ff93a8',
                $tomcat_exe              = 'tomcat6/tomcat.erb',
                $java_home               = '/usr/java/latest',
                $jvm_route               = 'jvm1',
                $shutdown_password       = 'SHUTDOWN',
                $admin_port              = 8005,
                $http_port               = 8080,
                $tomcat_user             = 'root',
                $tomcat_group            = 'root',
                $admin_user              = 'tomcat',
                $admin_password          = 'tomcat'
             ) {

  $basedir     = "${parentdir}/apache-tomcat-6.0.37"

  file {'/installs':
    ensure  => 'directory',
    source  => 'puppet:///modules/tomcat6/',
    recurse => 'remote',
    owner   => 'root',
    group   => 'root',
    mode    => '0755',
  }

  exec { 'tomcat_untar':
    command => 'tar -zxvf /installs/apache-tomcat-6.0.37.tar.gz -C /usr/share/',
    cwd     => '/usr/share/',
    creates => "/usr/share/apache-tomcat-6.0.37",
    path    => ["/bin"],
    require =>  [File["/installs"]]
  }

  file { "/etc/init.d/tomcat":
        ensure => present,
        owner  => root,
        group  => root,
        mode   => 0755,
        content => template($tomcat_exe),
        require => Exec["tomcat_untar"]
  }

    service { "tomcat":
        ensure  => "running",
        enable  => "true",
        require => File["/etc/init.d/tomcat"]
    } 
}

contents of tomcat.erb

#!/bin/bash
# description: Tomcat Start Stop Restart
# processname: tomcat
# chkconfig: 234 20 80
JAVA_HOME=/usr/java/jdk1.6.0_26
export JAVA_HOME
PATH=$JAVA_HOME/bin:$PATH
export PATH
CATALINA_HOME=/usr/share/apache-tomcat-6.0.37

case $1 in
start)
sh $CATALINA_HOME/bin/startup.sh
;;
stop)
sh $CATALINA_HOME/bin/shutdown.sh
;;
restart)
sh $CATALINA_HOME/bin/shutdown.sh
sh $CATALINA_HOME/bin/startup.sh
;;
esac
exit 0

Answer 1

Puppet does an /etc/init.d/tomcat status to see if the service is running. If it gets no proper return status if the service is stopped, it will not try to start it.

http://docs.puppetlabs.com/references/latest/type.html#service

Check out hasstatus.

An alternative is to make Puppet grep through the process table with 'pattern' and 'hasstatus' set to false.