How can I convert hamming number code in a while or for loop python

184 views Asked by At
def is_hamming_numbers(x):
    if x == 1:
        return 1
    if x % 2 == 0:
        return is_hamming_numbers(x/2)
    if x % 3 == 0:
        return is_hamming_numbers(x/3)
    if x % 5 == 0:
        return is_hamming_numbers(x/5)
    return 0

    def hamming_numbers_sequence(x):
        if x == 1:
            return 1
        hamming_numbers_sequence(x-1)
        if is_hamming_numbers(x) == True:
            print("%s" % x, end=' ')


    print(is_hamming_numbers(7))
    print(is_hamming_numbers(1))
    
    hamming_numbers_sequence(24)
    print()

Hi, I need to print the hamming numbers but I can only do it with the if loop. How can I do it with a for or while loop?

3

There are 3 answers

2
Gijs Wobben On BEST ANSWER

Something like this?

def is_hamming_numbers(x: int) -> bool:
    if x == 1:
        return True
    if x % 2 == 0:
        return is_hamming_numbers(x/2)
    if x % 3 == 0:
        return is_hamming_numbers(x/3)
    if x % 5 == 0:
        return is_hamming_numbers(x/5)
    return False


for n in range(1, 25):
    if is_hamming_numbers(n):
        print(n)
0
Tejas On

Another way to check and print hamming numbers, hope this helps.

Python Code:

# Hamming number has only prime factors as 2,3,5

def is_hamming_number(n):
    
    factors = [];
    
    hammingNumberCheck = {1,2,3,5,n}
    
    for i in range(1, n + 1):
        if n % i == 0:
            factors.append(i)
    
    factors_set = set(factors)
    
    if(factors_set.issubset(hammingNumberCheck)):
        return ":" + str(n) + ", is a hamming number"
    else:
        return ":" + str(n) + ", is not a hamming number"

print (is_hamming_number(10))

Ans - :10, is a hamming number

0
solid.py On

This implementation uses a priority queue, implemented with a heap.

from heapq import heappush, heappop
from itertools import islice
 
def hamming_number_seq():
    heap = [1]
    while True:
        h = heappop(heap)
        while heap and h == heap[0]:
            heappop(heap)
        for m in [2,3,5]:
            heappush(heap, m*h)
        yield h
 
print(*(islice(hamming_number_seq(), 15))) # This prints the first 15 numbers of the sequence.

Output:

1 2 3 4 5 6 8 9 10 12 15 16 18 20 24