Go over each word in a filter

Question

I feel like i'm coming up against a brick wall.

I've made a profanity filter, however this currently works when one bad word is entered, when more words (bad or otherwise) are entered it no longer filters and submits fine.

I'd like it to not submit if there are bad words present inside the input.

Here's what i've written so far:

var filterArray;
var inputArray;

$("button").on("click",function() {
    var input = $("input:text").val().toLowerCase();
    var inputArray = input.split(' ');

    console.log(inputArray);

    //for each item in inputArray
    $.each(inputArray, function() {
        if($.inArray(input, filterArray) !==-1)
        {
            console.log('Sorry you should not say ' + input + '!');
            return false;
        } else {
            console.log('passes');
        }
    });
});


$.ajax({
    async: false,
    url : "js/vendor/badwords.txt",
    dataType: "text",
    success : function (data) {

        filterArray = data.split(',');

    }
});

Any help would be appreciated, thank you!

Answer 1

you need to return true/false from the click handler instead you are just returning from the each() callback method.

$("button").on("click", function () {
    var input = $("input:text").val().toLowerCase();
    var inputArray = input.split(' ');

    console.log(inputArray);

    var valid = true;

    //for each item in inputArray
    $.each(inputArray, function (i, value) {
        //also need to use the current value in the inputArray
        if ($.inArray(value, filterArray) !== -1) {
            console.log('Sorry you should not say ' + value + '!');
            valid = false;
            //returning false from here stops the loop but don't prevent the default action of the button click
            return false;
        } else {
            console.log('passes');
        }
    });

    //return the valid state
    return valid;
});

Demo: Fiddle

Answer 2

Replace if($.inArray(input, filterArray) !==-1) with if($.inArray($(this), filterArray) !==-1). This should check every word in the array. Currently, it only looks at the first work multiple times.