Capistrano deploy fails with react_on_rails when NPM is installed via NVM

Question

The failing command cd client && npm run build:production comes from https://github.com/shakacode/react_on_rails/blob/master/lib/tasks/assets.rake

When using capistrano-npm and capistrano-nvm it creates /tmp/my_app_name/nvm-exec.sh with these contents and uses it to run npm install for package.json in the root rails app. But it is not used to run commands for React client.

#!/bin/bash -e
source "$HOME/.nvm/nvm.sh"
nvm use $NODE_VERSION
exec "$@"

Here is the output:

cap production deploy
rvm 1.27.0 (latest) by Wayne E. Seguin <[email protected]>, Michal Papis <[email protected]> [https://rvm.io/]
ruby-2.3.1
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
00:00 nvm:wrapper
      01 mkdir -p /tmp/rails_cap_deploy/
    ✔ 01 [email protected] 0.034s
      Uploading /tmp/my_app_name/nvm-exec.sh 100.0%
... 
...
00:16 npm:install
      01 /tmp/my_app_name/nvm-exec.sh npm install --production --silent --no-progress
      01 Now using node v6.9.2 (npm v3.10.9)
    ✔ 01 [email protected] 4.370s
00:20 deploy:assets:precompile
      01 ~/.rvm/bin/rvm default do bundle exec rake assets:precompile
      01 cd client && npm run build:production
      01
      01 sh: 1:
      01 npm: not found
      01
      01 rake aborted!
      01 Command failed with status (127): [cd client && npm run build:production...]
      01 /opt/my_app_name/stg/shared/bundle/ruby/2.3.0/gems/react_on_rails-6.3.2/lib/tasks/assets.rake:33:in `block (3 levels) in <top (required)>'
      01 /opt/my_app_name/stg/shared/bundle/ruby/2.3.0/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
      ...
      01 Tasks: TOP => assets:precompile => react_on_rails:assets:compile_environment => react_on_rails:assets:webpack
      01 (See full trace by running task with --trace)
(Backtrace restricted to imported tasks)
cap aborted!
SSHKit::Runner::ExecuteError: Exception while executing as [email protected]: rake exit status: 1
rake stdout: Nothing written
rake stderr: cd client && npm run build:production
sh: 1: npm: not found
rake aborted!
Command failed with status (127): [cd client && npm run build:production...]

Here are my dependencies:

Ubuntu 16.04
rvm 1.27.0
ruby-2.3.1
NPM - 3.10.9
NODE - v6.9.2
NVM - 0.32.1

Gems:
rails (5.0.0.1)
react_on_rails (6.3.2)
capistrano (3.7.0)
capistrano-npm (1.0.2)
capistrano-nvm (0.0.6)
capistrano-passenger (0.2.0)
capistrano-rails (1.2.0)
capistrano-bundler (~> 1.1)
capistrano-rvm (0.1.2)

Capfile:
require 'capistrano/npm'
require 'capistrano/nvm'

Answer 1

Here is how I "fixed" it. In my assets.rake used by react_on_rails I modified the webpack task.

  desc "Compile assets with webpack"
  task :webpack do
    # => prefix commands with /tmp/amplo/nvm-exec.sh on AWS servers
    # => http://stackoverflow.com/questions/41174807/capistrano-deploy-fails-with-react-on-rails-when-npm-is-installed-via-nvm
    nvm_prefix = '/tmp/amplo/nvm-exec.sh' if File.exist?('/tmp/amplo/nvm-exec.sh')
    sh "cd client && #{nvm_prefix} npm install"
    sh "cd client && #{nvm_prefix} npm run build:client"
    sh "cd client && #{nvm_prefix} npm run build:server"
  end

assets.rake file was included in my application before but later version of react_on_rails do not automatically copy this file into lib\tasks