Auto-properties and structs

Question

I am wondering about the following C#-code:

struct Structure
{
    public Structure(int a, int b)
    {
        PropertyA = a;
        PropertyB = b;
    }
    public int PropertyA { get; set; }
    public int PropertyB { get; set; }
}

It is not compiling with an error "The 'this' object cannot be used before all of its fields are assigned to". For the analogous class it is compiling without any problems.

It can be made working by refactoring to the following:

struct Structure
{
    private int _propertyA;
    private int _propertyB;

    public Structure(int a, int b)
    {
        _propertyA = a;
        _propertyB = b;
    }

    public int PropertyA
    {
        get { return _propertyA; }
        set { _propertyA = value; }
    }

    public int PropertyB
    {
        get { return _propertyB; }
        set { _propertyB = value; }
    }
}

But, I though that the whole point of introducing auto-properties to the C# was to avoid writing later code. Does that mean that auto-properties are not relevant for the structs?

Answer 1

In C# 6, this simply goes away; the code in the question compiles fine.

---

While Stefan has the answer than addresses the question, I have to advise you not to use a mutable struct - it will bite you. Mutable structs are evil.

IMO, the "correct" fix here is simply:

struct Structure
{
    public Structure(int a, int b)
    {
        propertyA = a;
        propertyB = b;
    }
    private readonly int propertyA, propertyB;
    public int PropertyA { get { return propertyA; } }
    public int PropertyB { get { return propertyB; } }
}

Answer 2

You need to call the default constructor first, like so:

struct Structure
{
    public Structure(int a, int b) : this()
    {
        PropertyA = a;
        PropertyB = b;
    }
    public int PropertyA { get; set; }
    public int PropertyB { get; set; }
}

Answer 3

As you've seen, when referring to PropertyA in your constructor, you're accessing the this object, which the compiler won't allow because your fields haven't been initialized yet.

To get around this, you need to find a way to initialize the fields. One way is your example: If you don't use auto-properties, then the fields are explicit and you can initialize them.

Another way is to have your constructor call another constructor that initializes the fields. Structs always implicitly have a parameterless constructor that initializes its fields to zero, so use that:

public Structure(int a, int b)
    : this()
{
    PropertyA = a;
    PropertyB = b;
}